Skip to content

[Hotfix] Cherry-pick to release-v0.179.6 - #1449

Open
truefoundry-saas wants to merge 3 commits into
release-v0.179.6from
cherry-pick/44a73633-803b-4bf5-89b4-5bc3fc59e4fa/release-v0.179.6
Open

truefoundry-saas wants to merge 3 commits into
release-v0.179.6from
cherry-pick/44a73633-803b-4bf5-89b4-5bc3fc59e4fa/release-v0.179.6

Conversation

@truefoundry-saas

@truefoundry-saas truefoundry-saas commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Automated cherry-pick for release request 44a73633-803b-4bf5-89b4-5bc3fc59e4fa.

Source PRs (merged to main):

Also landing with this hotfix:

These two are already on release-v0.179.6, manually cherry-picked by #1447.

Warning

This PR does not contain the fix yet. The cherry-pick conflicted, so
automation stopped at the first conflicting commit and left the rest out.
GitHub therefore shows this PR as mergeable, with no conflict to resolve —
it currently carries no changes at all (an empty placeholder commit).
Paste the prompt below into any coding agent that has this repository open.
It checks out this branch, applies the missing commits, and pushes.
Do not merge the PR. The release request checks every commit within a few
minutes (or use "Sync status" on it). The PR is merged when the request is
approved — or, if it is already approved, when a QA member or engineering
admin uses "Retry merge".

Agent prompt — copy from here:

Apply the missing cherry-pick commits onto this pull request. Work only in this repository. Do not merge the pull request and do not open a new one.

Repository: truefoundry/trueforge
Branch to check out and push to: cherry-pick/44a73633-803b-4bf5-89b4-5bc3fc59e4fa/release-v0.179.6
Base branch (do not commit onto this directly): release-v0.179.6
The first commit conflicted in: .github/fern/openapi/openapi.json, docs/openapi.json, packages/trueforge/tests/unit/truefoundry/TrueFoundryMcpServerStore.test.ts, python/trueforge_sdk/reference.md.

Commits still missing, in this order:
1. 584a376708b64b7738e3c925c533793dd628cda6

Steps:
1. Fetch and check out the branch above.
2. For each missing commit, in the order listed, run `git cherry-pick -x <sha>`. Keep the `-x`: the release request confirms a commit from the "cherry picked from" line it writes.
3. If a cherry-pick conflicts, resolve it so that commit's changes land on this branch, then `git add` the resolved files and `git cherry-pick --continue`. Do not skip a commit and do not abort the sequence.
4. Push to the same branch. This pull request updates on its own.
5. Stop. Do not merge the pull request.

Conflicting file(s):

  • .github/fern/openapi/openapi.json
  • docs/openapi.json
  • packages/trueforge/tests/unit/truefoundry/TrueFoundryMcpServerStore.test.ts
  • python/trueforge_sdk/reference.md

Commits still to apply (starting at the conflict):

  • 584a376708b64b7738e3c925c533793dd628cda6

Do not merge manually — this PR is merged automatically when the release request is approved. If you do merge it yourself, use "Sync status" on the request so it stops showing as pending.


Note

Low Risk
Targeted OAuth redirect behavior and input validation on an optional query param, with tests and no broad auth refactors.

Overview
MCP authorize return_to is now truly optional. On GET /api/v1/mcp-servers/{name}/authorize, when return_to is not provided the TrueFoundry MCP gateway call omits redirectURL, so users see the gateway’s default post-auth page instead of being redirected into TrueForge.

Stricter query validation: an explicit empty return_to is rejected (400) via minLength: 1 on the route schema and handler checks that run when the parameter is present (returnTo !== undefined). OpenAPI, Fern SDK types, and Python SDK docs are aligned with “omit = no redirect.”

Upstream behavior: TrueFoundryMcpServerStore.authorize only resolves and passes redirectURL when returnTo is set; tenant control-plane URL lookup is skipped when no redirect is requested. Unit tests cover empty return_to and the no-redirectURL path.

Reviewed by Cursor Bugbot for commit 58d4f37. Bugbot is set up for automated code reviews on this repo. Configure here.

@chiragjn chiragjn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs 1 fix

Co-authored-by: Cursor <cursoragent@cursor.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants